TrackをModelに切り出し、ソートを可能にする #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-ikuta
approved these changes
Apr 8, 2024
exSOUL
reviewed
Apr 8, 2024
| @@ -5,7 +5,7 @@ class Table | |||
| attr_reader :track_list, :rows | |||
|
|
|||
| def initialize(schedules) | |||
| @track_list = schedules.map(&:track_name).sort.uniq | |||
| @track_list = schedules.map(&:track).uniq.sort_by(&:position).map(&:name) | |||
There was a problem hiding this comment.
このあたりN+1発生するのでは？と思って処理追ってみましたが、app/controllers/schedules_controller.rb の @schedules を使っているので多分大丈夫だな、となりました
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
既存のScheduleモデルでは、track_nameを文字列として保持しているため、ソートのロジックが文字列ソートになる。
文字列では対応できないソートも存在するため、新たにTackモデルを作成し、positionを設定することでソートを可能にした。